codeimport commented on a change in pull request #9613:
URL: https://github.com/apache/dubbo/pull/9613#discussion_r790391015
##########
File path:
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/ForkingClusterInvoker.java
##########
@@ -96,7 +93,7 @@ public Result doInvoke(final Invocation invocation,
List<Invoker<T>> invokers, L
});
}
try {
- Object ret = ref.poll(timeout, TimeUnit.MILLISECONDS);
+ Object ret = ref.poll(Integer.MAX_VALUE,
TimeUnit.MILLISECONDS);
Review comment:
Thank you for your suggestion. I understand what you mean, but if the
provider side times out, an exception will be caught here and put into the
queue, so the poll method will not return any null. There should be no other
exceptions。
` try {
Result result = invokeWithContextAsync(invoker,
invocation, consumerUrl);
ref.offer(result);
} catch (Throwable e) {
int value = count.incrementAndGet();
if (value >= selected.size()) {
ref.offer(e);
}
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
