BurningCN commented on code in PR #10380:
URL: https://github.com/apache/dubbo/pull/10380#discussion_r932403372
##########
dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/ServiceBean.java:
##########
@@ -104,6 +104,13 @@ public void afterPropertiesSet() throws Exception {
moduleModel.getDeployer().setPending();
}
+ @Override
+ public void unexport() {
+ ModuleModel moduleModel =
DubboBeanUtils.getModuleModel(applicationContext);
+ moduleModel.getConfigManager().removeConfig(this);
Review Comment:
我想了下，我刚才的理解还是有些偏差的。刚看了下每次ReferenceConfig#destroy的时候也会从configManager移除，所以对应ServiceConfig#unexport应该也有。不过我想这个逻辑是不是放在ServiceConfig里，而不是ServiceBean里？（比如用户直接以api的方式配置一个ServiceConfig，压根就没用spring相关的）
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
