[GitHub] [dubbo] BurningCN commented on a diff in pull request #10380: Module config no support unexport

Thu, 28 Jul 2022 09:04:15 -0700 


BurningCN commented on code in PR #10380:
URL: https://github.com/apache/dubbo/pull/10380#discussion_r932415597


##########
dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/ServiceBean.java:
##########
@@ -104,6 +104,13 @@ public void afterPropertiesSet() throws Exception {
         moduleModel.getDeployer().setPending();
     }
 
+    @Override
+    public void unexport() {
+        ModuleModel moduleModel = 
DubboBeanUtils.getModuleModel(applicationContext);
+        moduleModel.getConfigManager().removeConfig(this);

Review Comment:
   可以看如下demo，不是通过ServiceBean的方式，直接是ServiceConfig。
   
我上面表达的意思是Spring配置方式不是ServiceBean/Config唯一加入configManager的方式。如果按照如下这配置方式，按照目前pr的修改逻辑，在unexport就不会从configManager移除了。
   
   
![image](https://user-images.githubusercontent.com/43363120/181582137-12c2bfab-aa4d-4aa1-871c-7b0b85724956.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to