owen200008 commented on code in PR #10380:
URL: https://github.com/apache/dubbo/pull/10380#discussion_r932424348
##########
dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/ServiceBean.java:
##########
@@ -104,6 +104,13 @@ public void afterPropertiesSet() throws Exception {
moduleModel.getDeployer().setPending();
}
+ @Override
+ public void unexport() {
+ ModuleModel moduleModel =
DubboBeanUtils.getModuleModel(applicationContext);
+ moduleModel.getConfigManager().removeConfig(this);
Review Comment:
加入和删除一起迁移到父类我觉得是OK的
目前还是保持统一在bean中加入和删除更合适
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
