ctubbsii commented on a change in pull request #995: fixes #980
URL: https://github.com/apache/fluo/pull/995#discussion_r162149226
##########
File path: modules/core/pom.xml
##########
@@ -141,6 +132,34 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <relocations>
+ <relocation>
+ <pattern>org.apache.thrift</pattern>
+ <shadedPattern>org.shaded.thrfit</shadedPattern>
+ </relocation>
+ </relocations>
+ <artifactSet>
+ <includes>
+ <include>org.apache.fluo.core.*</include>
+ <include>org.shaded.thrift:*</include>
+ <include>org.apache.thrift:*</include>
+ </includes>
+ </artifactSet>
+ <createDependencyReducedPom>false</createDependencyReducedPom>
Review comment:
If this POM is created, I wonder if it would replace the original POM when
installed to the local maven repository or deployed to the remote maven
repository. If so, it may be useful to let the plugin create this. See comment
above about libthrift dependency being resolved transitively.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
