ctubbsii commented on a change in pull request #995: fixes #980
URL: https://github.com/apache/fluo/pull/995#discussion_r165750259
 
 

 ##########
 File path: modules/core/pom.xml
 ##########
 @@ -73,6 +73,10 @@
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-client</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.apache.thrift</groupId>
+      <artifactId>libthrift</artifactId>
 
 Review comment:
   It changed a few things... interesting things... but not important things. 
The reduced POM looks like our POM, so that's good. I'll check the jar contents 
manually just to do a quick sanity check, but so far, everything looks the way 
I'd expect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to