ctubbsii commented on a change in pull request #995: fixes #980
URL: https://github.com/apache/fluo/pull/995#discussion_r162147758
##########
File path: modules/core/pom.xml
##########
@@ -73,6 +73,10 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.thrift</groupId>
+ <artifactId>libthrift</artifactId>
Review comment:
I think this still needs to be `<scope>provided</scope>`, or perhaps
`<optional>true</optional>` in order to prevent transitive dependency
resolution by consumers of the fluo-core jar. That is, unless the shade plugin
also modifies the POM to exclude libthrift... and I'm not sure it does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
