keith-turner commented on a change in pull request #1004: FLUO-1000
OracleServer race conditions
URL: https://github.com/apache/fluo/pull/1004#discussion_r162742462
##########
File path:
modules/core/src/main/java/org/apache/fluo/core/oracle/OracleServer.java
##########
@@ -195,18 +195,25 @@ public OracleServer(Environment env) throws Exception {
private void allocateTimestamp() throws Exception {
Stat stat = new Stat();
- byte[] d =
curatorFramework.getData().storingStatIn(stat).forPath(maxTsPath);
+ // FLUO-1000
+ synchronized (this) {
Review comment:
I don't think adding this synchronized block has any effect because this
method is only called from a synchronized method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
