keith-turner commented on a change in pull request #1004: FLUO-1000
OracleServer race conditions
URL: https://github.com/apache/fluo/pull/1004#discussion_r162749129
##########
File path:
modules/core/src/main/java/org/apache/fluo/core/oracle/OracleServer.java
##########
@@ -410,15 +417,18 @@ public void takeLeadership(CuratorFramework
curatorFramework) throws Exception {
}
synchronized (this) {
+ // FLUO-1000
+ isLeader = true;
+ while
(!curatorFramework.getState().equals(CuratorFrameworkState.STARTED)) {
Review comment:
Would it make sense to move this loop the `OracleServer.start()` method
after `curatorFramework.start()` is called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
