keith-turner commented on a change in pull request #1004: FLUO-1000 
OracleServer race conditions
URL: https://github.com/apache/fluo/pull/1004#discussion_r193213784
 
 

 ##########
 File path: 
modules/core/src/main/java/org/apache/fluo/core/oracle/OracleServer.java
 ##########
 @@ -410,15 +417,18 @@ public void takeLeadership(CuratorFramework 
curatorFramework) throws Exception {
       }
 
       synchronized (this) {
+        // FLUO-1000
+        isLeader = true;
 
 Review comment:
   @kpm1985  after 9b5277c9c79bb3a52bb879af591d1c51ae9476cc, I think this may 
be the only change in this PR that still need to be made.  It still makes sense 
to set isLeader before starting gcTsTracker.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to