jkosh44 commented on a change in pull request #1083: [WIP] POC for Command 
module with centralized Command Pattern logic
URL: https://github.com/apache/fluo/pull/1083#discussion_r357472316
 
 

 ##########
 File path: modules/command/src/main/java/org/apache/fluo/command/FluoExec.java
 ##########
 @@ -44,25 +50,39 @@ protected void configure() {
     }
   }
 
-  public static void main(String[] args) throws Exception {
-    if (args.length < 2) {
-      System.err.println("Usage: fluo exec <app> <class> args...");
-      System.exit(-1);
+  @Parameter(description = "<app> <class> args...", variableArity = true)
+  private List<String> args;
 
 Review comment:
   It would be nice to be able to have three fields `String app`, `String 
class`, and `List<String> args`. However I couldn't get this to work with 
JCommander which is why there's just a single field `List<String> args`. I'm 
going to keep trying to see if I can get it to work with three fields.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to