jkosh44 commented on a change in pull request #1083: [WIP] POC for Command module with centralized Command Pattern logic URL: https://github.com/apache/fluo/pull/1083#discussion_r357471312
########## File path: modules/command/src/main/java/org/apache/fluo/command/FluoCommandRunner.java ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ + +package org.apache.fluo.command; + +public class FluoCommandRunner { Review comment: This class could probably be combined with the `FluoProgram` class. It might be better to have the logic of both of these classes in the same place. I'm interested to hear others opinions on it. From the Command Pattern I tried to make this the Invoker class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
