jkosh44 commented on a change in pull request #1083: [WIP] POC for Command
module with centralized Command Pattern logic
URL: https://github.com/apache/fluo/pull/1083#discussion_r357474242
##########
File path: modules/distribution/src/main/scripts/fluo
##########
@@ -131,50 +131,50 @@ function setup_service {
case "$1" in
Review comment:
I'm not as proficient at shell scripting as I'd like to be so any comments
on this file would be greatly appreciated. Now that the same class is being
used as the entry point for almost all commands this script looks a little
redundant. I feel like there may be ways of condensing it, but I didn't want to
attempt to much in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
