arvindshmicrosoft commented on a change in pull request #340: Cleanup Python and Ansible Code URL: https://github.com/apache/fluo-muchos/pull/340#discussion_r409043973
########## File path: .travis.yml ########## @@ -15,4 +15,11 @@ language: python python: - "3.5" -script: nosetests -w lib/ +install: + - pip install flake8 + - pip install ansible-lint +script: + - nosetests -w lib/ + - ansible-lint -x 204,301 Review comment: Thanks Keith. * I excluded 204 for now given the risk / reward consideration in refactoring the few longer-than-160-chars lines in Ansible playbooks. I will add a comment in the CI script to note that this is a future TODO. * 301 is more interesting. It is flagged for specific cases where we set a fact based on a command output, without a when condition or creates condition. Such actions are necessarily repeated always by Ansible and hence are flagged. Again, I will flag this for a future TODO. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
