ctubbsii commented on a change in pull request #340: Cleanup Python and Ansible Code URL: https://github.com/apache/fluo-muchos/pull/340#discussion_r409251801
########## File path: .travis.yml ########## @@ -15,4 +15,11 @@ language: python python: - "3.5" -script: nosetests -w lib/ +install: + - pip install flake8 + - pip install ansible-lint +script: + - nosetests -w lib/ + - ansible-lint -x 204,301 + - flake8 + - git ls-files | tr '\n' '\0' | xargs -0 -L1 bash -c 'if test "$(grep --files-with-matches --binary-files=without-match --max-count=1 --regexp='.*' "$0")" && test "$(tail --bytes=1 "$0")"; then echo "No new line at end of $0."; false; fi' Review comment: Thanks for the update. I think the separate script is definitely better. I made a few additional notes, but will resolve this comment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
