arvindshmicrosoft commented on a change in pull request #340: Cleanup Python
and Ansible Code
URL: https://github.com/apache/fluo-muchos/pull/340#discussion_r409046027
##########
File path: ansible/roles/azure/tasks/create_adlsgen2.yml
##########
@@ -56,26 +58,26 @@
with_sequence: start=1 end={{ InstanceVolumesEndSequence|int }}
when: InstanceVolumesTemp[0]|int != 0
-- name: Retrieve ABFSS values when specified manually
+- name: Retrieve ABFSS values when specified manually
set_fact:
InstanceVolumesManual: "{{ InstanceVolumesManual + [ item ] }}"
loop:
"{{ InstanceVolumesTemp }}"
when: item.split('://')[0] == 'abfss' and
instance_volumes_input.split('|')[0].split(',') == ['']
-# This is final list of instance volumes
+# This is final list of instance volumes
- name: Assign variables for autogeneration or manual for storage account
creation
set_fact:
- InstanceVolumes: "{{ InstanceVolumesManual if
instance_volumes_input.split('|')[0].split(',') == [''] else
InstanceVolumesAuto }}"
+ InstanceVolumes: "{{ InstanceVolumesManual if
instance_volumes_input.split('|')[0].split(',') == [''] else
InstanceVolumesAuto }}"
- name: Update instance_volumes_preferred in muchos.props
lineinfile:
path: "{{ deploy_path }}/conf/muchos.props"
regexp:
'^instance_volumes_preferred\s*=\s*|^[#]instance_volumes_preferred\s*=\s*'
line: "instance_volumes_preferred = {{ InstanceVolumes|join(',') }}"
-# Not registering variable because storage values are not visible immediately
-- name: Create ADLS Gen2 storage acount using REST API
+# Not registering variable because storage values are not visible immediately
+- name: Create ADLS Gen2 storage account using REST API
Review comment:
I was told about
[Arcolinx](https://docs.acrolinx.com/visualstudio/latest/en) by one of my
colleagues and installed its plugin for VSCode (which is the IDE I use). It has
a spellcheck built in, and indeed it did catch this and a few others as well.
In due course, we can look for a solution which can be integrated into the CI
itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
