karthick-rn commented on a change in pull request #395:
URL: https://github.com/apache/fluo-muchos/pull/395#discussion_r647300859
##########
File path: ansible/group_vars/.gitignore
##########
@@ -1 +1 @@
-/all
+/*
Review comment:
Looks like the `.gitignore` file is not ignored and still being tracked
even if I don't explicitly whitelist `!.gitignore` as specified in the link. I
have tested the below scenarios, let me know if I'm missing anything? Thanks
```
(env) [knarendran@kn-centos75-jbox fluo-muchos]$ git diff
diff --git a/ansible/group_vars/.gitignore b/ansible/group_vars/.gitignore
index 33662f5..4ef7868 100644
--- a/ansible/group_vars/.gitignore
+++ b/ansible/group_vars/.gitignore
@@ -1 +1,2 @@
-/*
+# Ignore everything in this directory
+*
(env) [knarendran@kn-centos75-jbox fluo-muchos]$ git status
# On branch karthick/azure_validations
# Changes not staged for commit:
# (use "git add <file>..." to update what will be committed)
# (use "git checkout -- <file>..." to discard changes in working directory)
#
# modified: ansible/group_vars/.gitignore
#
no changes added to commit (use "git add" and/or "git commit -a")
```
```
(env) [knarendran@kn-centos75-jbox fluo-muchos]$ git diff
diff --git a/ansible/group_vars/.gitignore b/ansible/group_vars/.gitignore
index 33662f5..5e7d273 100644
--- a/ansible/group_vars/.gitignore
+++ b/ansible/group_vars/.gitignore
@@ -1 +1,4 @@
-/*
+# Ignore everything in this directory
+*
+# Except this file
+!.gitignore
(env) [knarendran@kn-centos75-jbox fluo-muchos]$ git status
# On branch karthick/azure_validations
# Changes not staged for commit:
# (use "git add <file>..." to update what will be committed)
# (use "git checkout -- <file>..." to discard changes in working directory)
#
# modified: ansible/group_vars/.gitignore
#
no changes added to commit (use "git add" and/or "git commit -a")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
