ctubbsii commented on a change in pull request #395:
URL: https://github.com/apache/fluo-muchos/pull/395#discussion_r647575845
##########
File path: ansible/group_vars/.gitignore
##########
@@ -1 +1 @@
-/all
+/*
Review comment:
It looks like it works without excluding it because `*` doesn't match on
dotfiles (so no dotfiles would be ignored). However, that might be
platform-dependent, since dotfiles are considered "hidden" on \*nix systems,
but not necessarily on others. The file-globbing pattern matching might be
different on different systems... I'm not sure. If you wanted to ignore
dotfiles, too, then you would probably have to add `.*` and `!.gitignore`
explicitly. I'm fine with whatever works, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
