karthick-rn commented on a change in pull request #395:
URL: https://github.com/apache/fluo-muchos/pull/395#discussion_r647815676
##########
File path: ansible/group_vars/.gitignore
##########
@@ -1 +1 @@
-/all
+/*
Review comment:
The objective is to commit the `.gitignore` file & ignore the rest of
the files in that directory. Also, that is the only dotfile in the directory.
In general, I think git doesn't ignore the `.gitignore` files. For instance, if
we add `.*` or `.gitignore` git still doesn't ignore it and `git status`
reports the file has been modified. Not sure if it's a git thing. Just to be
safe, I'll go ahead and explicitly whitelist as mentioned in the above link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
