ctubbsii commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r780065250
##########
File path: ansible/accumulo.yml
##########
@@ -53,26 +53,32 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.x master, monitor, and gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }}
start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is
version('2.1.0','<') and not use_systemd
Review comment:
To be equivalent to what's in the other task, I think you also need:
```suggestion
when: accumulo_version is version('2.0.0','>=') and accumulo_version
is version('2.1.0','<') and not use_systemd
register: start_tracer_result
changed_when: "'Starting' in start_tracer_result.stdout"
```
##########
File path: ansible/accumulo.yml
##########
@@ -53,26 +53,32 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.x master, monitor, and gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }}
start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is
version('2.1.0','<') and not use_systemd
Review comment:
To be equivalent to what's in the other task, I think you also need:
```suggestion
register: start_tracer_result
changed_when: "'Starting' in start_tracer_result.stdout"
when: accumulo_version is version('2.0.0','>=') and accumulo_version
is version('2.1.0','<') and not use_systemd
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
