keith-turner commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r781480546



##########
File path: ansible/accumulo.yml
##########
@@ -53,16 +53,18 @@
       when: accumulo_major_version == '2' and not use_systemd
 - hosts: accumulomaster
   tasks:
-    - name: "start accumulo 2.0 master, monitor, gc & tracer"
+    - name: "start accumulo 2.0 master, monitor, & gc"
       command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} 
start"
       register: start_result
       changed_when: "'Starting' in start_result.stdout"
       with_items:
         - master
         - monitor
         - gc
-        - tracer
       when: accumulo_major_version == '2' and not use_systemd
+    - name: "start accumulo 2.0 tracer"
+      command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+      when: accumulo_version is version('2.0.0','>=') and accumulo_version is 
version('2.1.0','<') and not use_systemd
 - hosts: accumulomaster
   tasks:
     - name: "install and start all the accumulo services using systemd"

Review comment:
       > BTW, unrelated to this change, the accumulo-cluster-systemd also 
errors out due to lack of change to manager from the older term. That is an 
unrelated issue and can be cleaned up separately.
   
   I made one small change related to this in daeab54 because I was touching 
that code.  Looking at the file its pervasive , so would be nicer to do that in 
its own PR.  I wonder if we can avoid a bunch of if stmts in the template and 
just have template variable that resolves to manager or master.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to