arvindshmicrosoft commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r780602067
##########
File path: ansible/accumulo.yml
##########
@@ -53,16 +53,18 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.0 master, monitor, & gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }}
start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is
version('2.1.0','<') and not use_systemd
- hosts: accumulomaster
tasks:
- name: "install and start all the accumulo services using systemd"
Review comment:
@keith-turner - I did test your latest changes with
accumulo-2.1.0-SNAPSHOT built off accumulo main, with systemd enabled. While
setup did complete without any errors, the observations from @brianloss need to
be addressed sometime - especially the accumulo-cluster-systemd script errors
out.
BTW, unrelated to this change, the accumulo-cluster-systemd also errors out
due to lack of change to `manager` from the older term. That is an unrelated
issue and can be cleaned up separately.
##########
File path: ansible/accumulo.yml
##########
@@ -53,26 +53,32 @@
when: accumulo_major_version == '2' and not use_systemd
- hosts: accumulomaster
tasks:
- - name: "start accumulo 2.0 master, monitor, gc & tracer"
+ - name: "start accumulo 2.x master, monitor, and gc"
command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }}
start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
with_items:
- master
- monitor
- gc
- - tracer
when: accumulo_major_version == '2' and not use_systemd
+ - name: "start accumulo 2.0 tracer"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+ when: accumulo_version is version('2.0.0','>=') and accumulo_version is
version('2.1.0','<') and not use_systemd
Review comment:
yes, what this would do is to make Ansible report a green "ok" status
for that play / task, when tracer is already running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
