chrisrueger commented on PR #103: URL: https://github.com/apache/freemarker/pull/103#issuecomment-1868373883
> So is it already reproducible with this little change? This change at least makes the (linux) file-timestamps and permissions kinda static and removes timestamps from Manifest.MF. So yes to a large extend it is. Where I am unsure is the timestamps in the local build vs. release build e.g. `Bundle-Version 2.3.33.nightly_20231222T192537Z` which contains the timestamp of the build. But my assumption was that the "real" release build won't have the timestamp. Maybe you could try to do a preview of a real release build without the timestamps (or tell me how). In theory your build and my build should look exactly the same if the build has no timestamp in the version. But I am not an expert. We could start with this. I think more information can be found [here](https://reproducible-builds.org/docs/definition/) also a list of [tools](https://reproducible-builds.org/tools/) to verify it. > * Regarding download the exact JDK-s (`foojay-resolver-convention`)... quite brutal, but, I guess, nobody cares about a few tens of megabytes anymore. Feel free to remove this commit about `foojay-resolver-convention` if you have concerns. Maybe I shouldn't have included it here. Was more a suggestion based on my recent comment. Should I revert it? Only the first commit 1f9800ca8784a17c5c81eccbc32160a5cf1d1f0d is related to reproducibility. > * `gradlew` should remain executable. Not sure I understand. I have used `./gradlew jar` to build. So I would say, yes it is still executable. > * Also, we must not attempt to print the build date in `freemarker.core.CommandLine` anymore then Not sure I understand how this relates to reproducible. Is this something affection the build result artifact (freemarker.jar)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
