ddekany commented on PR #103:
URL: https://github.com/apache/freemarker/pull/103#issuecomment-1868463531
So there's `freemarker.jar:freemarker/version.properties`, which contains a
`buildTimestamp`, that we fill for each build (see
`freemarker/build/FreemarkerVersionService.kt`). And that's what said command
line utility prints too. For the reproducible build this feature has to be
removed in effect.
The version number itself has no date in a release (see in
`freemarker.jar:freemarker/version.properties`), but as per above, the build
still won't be reproducible until we stop filling the `buildTimestamp`.
`foojay-resolver-convention`: Ah, it only downloads if the given JDK is not
already found. But then, my question remains. If the build has to be
reproducible, then we had to be more specific than just "JDK 16", right?
`gradlew`: I meant, it's not executable in the source distribution tar.
`tar -tvf apache-freemarker-gae-src-2.3.33-SNAPSHOT.tgz` gives `-rw-r--r--
0/0 8941 1970-01-02 01:00 gradlew`.
But I just realized that that's already broken in the `2.3-gae` branch. But
I guess if I fix that these, the `filePermissions { unix("rw-r--r--") }` you
added will collide with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
