chrisrueger commented on PR #103: URL: https://github.com/apache/freemarker/pull/103#issuecomment-1869367561
> Now that that the timestamp causes complications, we should just change the convention to `version=2.3.33-nightly`. Ok, I will change that accordingly. > I say, we just keep it in the `Version` API, but mark it as deprecated, and always return `null`. (It was documented that it can return `null`, and it's quite unlikely that anyone even calls that method, and also fails on `null`.) That's the price of reproducible builds. The JUnit tests has to be adjusted for this. And all these change belongs to this PR of course. Ok, I will work on that. > Ironically, we did have the exact JDK version in the META-INF of `freemarker.jar`, but now that was removed because of reproducible builds, which makes it harder to actually reproduce the build for someone else. I just tested to make that possible again: I just removed the attribute `-noextraheaders: true` which I added (or set it to `false`) Then the following attributes are added back to `MANIFEST.MF` <img width="701" alt="image" src="https://github.com/apache/freemarker/assets/188422/14bbf3e7-fd43-47aa-b175-6f1721aefb4e";> I think that way we have it close to as it was before, but without timestamps. We could still think about an additional `buildinfo` file in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
