ddekany commented on code in PR #103:
URL: https://github.com/apache/freemarker/pull/103#discussion_r1436411641


##########
freemarker-core/src/main/java/freemarker/template/Version.java:
##########
@@ -42,7 +42,6 @@ public final class Version implements Serializable {
     private final String originalStringValue;
     
     private final Boolean gaeCompliant;
-    private final Date buildDate;

Review Comment:
   Admittedly this has near 0 practical importance, but... as `Version` has 
public constructor, and we allow passing in the build date, it would be more 
round if `getBuildDate()` still gives back the same value. Even if it will be 
almost always `null`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to