dschneider-pivotal commented on a change in pull request #5159:
URL: https://github.com/apache/geode/pull/5159#discussion_r432739787
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/RegionNameValidation.java
##########
@@ -24,7 +24,7 @@
public class RegionNameValidation {
- private static final Pattern NAME_PATTERN =
Pattern.compile("[aA-zZ0-9-_.]+");
+ private static final Pattern NAME_PATTERN =
Pattern.compile("[a-zA-Z\\[\\]0-9-_.]+");
Review comment:
I don't understand why you changed this Pattern. I think GEODE-7956 was
just about correcting the docs. It looks to me like you are expanding what a
legal region name is to include square brackets. Did this get approved in a
RFC? If not I think you should do so before this gets approved. In we end up
keeping square brackets in region names then update GEODE-7956 to say we should
and why it is valuable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
