dschneider-pivotal commented on a change in pull request #5159:
URL: https://github.com/apache/geode/pull/5159#discussion_r432741553
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/RegionNameValidation.java
##########
@@ -24,7 +24,7 @@
public class RegionNameValidation {
- private static final Pattern NAME_PATTERN =
Pattern.compile("[aA-zZ0-9-_.]+");
+ private static final Pattern NAME_PATTERN =
Pattern.compile("[a-zA-Z\\[\\]0-9-_.]+");
Review comment:
I see your comment now about the old regex allowing extra characters.
Can you enhance the RegionNameValidationTest to demonstrate that these were
allowed before. I think it would be safest to just document all the characters
already supported in a region name by the product and not change it. If someone
already put one of those characters in their region name we done want to break
them. I don't understand how the old regex let those sneak in. Did aA-zZ
include ^, `, [, ], and backslash somehow?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
