mkevo commented on a change in pull request #5159:
URL: https://github.com/apache/geode/pull/5159#discussion_r433090252
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/RegionNameValidation.java
##########
@@ -24,7 +24,7 @@
public class RegionNameValidation {
- private static final Pattern NAME_PATTERN =
Pattern.compile("[aA-zZ0-9-_.]+");
+ private static final Pattern NAME_PATTERN =
Pattern.compile("[a-zA-Z\\[\\]0-9-_.]+");
Review comment:
Yes, I agree. I also think that aA-zZ is the same as a-zA-Z.
The new regex will be **[a-zA-Z0-9-_.^`\[\]\\]+**. Is it ok with you?
This more clear to see what is included. I will also add separate tests for
all of these characters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
