pivotal-jbarrett commented on a change in pull request #137:
URL: https://github.com/apache/geode-benchmarks/pull/137#discussion_r525526788
##########
File path:
geode-benchmarks/src/main/java/org/apache/geode/benchmark/topology/ClientServerTopologyWithSniProxy.java
##########
@@ -58,23 +64,29 @@ public static SniProxyImplementation
valueOfIgnoreCase(String name) {
}
}
- public static void configure(final TestConfig config,
- final SniProxyImplementation sniProxyImplementation) {
+ public static void configure(final TestConfig config) {
role(config, LOCATOR, NUM_LOCATORS);
role(config, SERVER, NUM_SERVERS);
role(config, CLIENT, NUM_CLIENTS);
role(config, PROXY, NUM_PROXIES);
+ configureBefore(config);
+
+ before(config, new StartClientWithSniProxy(LOCATOR_PORT, SNI_PROXY_PORT,
PROXY), CLIENT);
Review comment:
Notice the subtlety of the router calling into here. It needs to start a
client with a different proxy address. That last arg that is `PROXY` here is
`ROUTER` in the router topology.
I could pull the StopClient out of the configuratAfter. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
