pivotal-jbarrett commented on a change in pull request #137:
URL: https://github.com/apache/geode-benchmarks/pull/137#discussion_r525527535
##########
File path:
geode-benchmarks/src/main/java/org/apache/geode/benchmark/topology/ClientServerTopologyWithSniProxy.java
##########
@@ -84,14 +96,23 @@ public static void configure(final TestConfig config,
case Manual:
// expect proxy already configured.
}
+ }
- before(config, new StartClientSNI(LOCATOR_PORT, SNI_PROXY_PORT), CLIENT);
-
+ protected static void configureAfter(final TestConfig config) {
after(config, new StopClient(), CLIENT);
- if (Manual != sniProxyImplementation) {
+ if (Manual != getSniProxyImplementation()) {
after(config, new StopSniProxy(), PROXY);
}
}
+ private static SniProxyImplementation getSniProxyImplementation() {
+ final String sniProp = System.getProperty(WITH_SNI_PROXY_PROPERTY);
Review comment:
It is probably doable but out of scope for this change. I really dislike
system properties too. Unfortunately the framework lacks a context that spans
all the hosts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
