pivotal-jbarrett commented on a change in pull request #137:
URL: https://github.com/apache/geode-benchmarks/pull/137#discussion_r525527971
##########
File path:
geode-benchmarks/src/test/java/org/apache/geode/benchmark/topology/ClientServerTopologyWithSniProxyTest.java
##########
@@ -44,9 +46,11 @@ public void afterEach() {
@ParameterizedTest
@EnumSource(SniProxyImplementation.class)
+ @ClearSystemProperty(key = WITH_SNI_PROXY_PROPERTY)
public void configWithNoSsl(final SniProxyImplementation
sniProxyImplementation) {
- TestConfig testConfig = new TestConfig();
- ClientServerTopologyWithSNIProxy.configure(testConfig,
sniProxyImplementation);
+ System.setProperty(WITH_SNI_PROXY_PROPERTY, sniProxyImplementation.name());
Review comment:
See previous comment... agree but out of scope.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
