upthewaterspout commented on a change in pull request #6122:
URL: https://github.com/apache/geode/pull/6122#discussion_r592761630
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/data/RedisHash.java
##########
@@ -59,17 +62,31 @@ public RedisHash() {
// for serialization
}
+
/**
* Since GII (getInitialImage) can come in and call toData while other
threads are modifying this
* object, the striped executor will not protect toData. So any methods that
modify "hash" needs
* to be thread safe with toData.
*/
@Override
- public synchronized void toData(DataOutput out) throws IOException {
- super.toData(out);
+ public void toData(DataOutput out, SerializationContext context) throws
IOException {
Review comment:
It looks like you removed synchronization on this method? Was that
intended?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
