dschneider-pivotal commented on a change in pull request #6122:
URL: https://github.com/apache/geode/pull/6122#discussion_r594494166
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/data/RedisString.java
##########
@@ -610,18 +613,26 @@ public int setbit(
* and call setBytes. So toData will see either the old or new value but
* not a mix of both.
*/
+
@Override
- public void toData(DataOutput out) throws IOException {
- super.toData(out);
+ public synchronized void toData(DataOutput out, SerializationContext
context) throws IOException {
Review comment:
toData has a lengthy comment explaining why it does not need to be
synchronized. It would be good to update that comment to explain why it needs
to be synchronized
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
