dschneider-pivotal commented on a change in pull request #6122:
URL: https://github.com/apache/geode/pull/6122#discussion_r594490821
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetOptions.java
##########
@@ -53,6 +63,31 @@ public boolean isKeepTTL() {
return keepTTL;
}
+ @Override
+ public int getDSFID() {
+ return REDIS_SET_OPTIONS_ID;
+ }
+
+ @Override
+ public void toData(DataOutput out, SerializationContext context) throws
IOException {
+ DataSerializer.writeObject(exists, out);
Review comment:
since "exists" is always an Enum of type Exists, its serialization can
be optimized by directly calling DataSerializer.writeEnum and readEnum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
