ringles commented on a change in pull request #6296:
URL: https://github.com/apache/geode/pull/6296#discussion_r618468958
##########
File path:
geode-apis-compatible-with-redis/src/test/java/org/apache/geode/redis/internal/data/RedisHashTest.java
##########
@@ -258,6 +258,13 @@ public void hscanSnaphots_shouldExpireAfterExpiryPeriod() {
});
}
+ @Test
+ public void
hashSizeOverhead_shouldNotBeChanged_withoutForethoughtAndTesting() {
+ assertThat(RedisHash.PER_OBJECT_OVERHEAD).isEqualTo(8);
+
assertThat(RedisHash.getPerStringOverhead()).isEqualTo(RedisHash.PER_OBJECT_OVERHEAD
+ 46);
+
assertThat(RedisHash.getPerHashOverhead()).isEqualTo(RedisHash.PER_OBJECT_OVERHEAD
+ 116);
+ }
Review comment:
I was able to get the Sets to be dynamic - however, the values didn't
change for Java 8, Java 11, and Liberica v8. Hashes are more complicated - the
numbers just don't seem to add up, trying to figure things out from inside the
constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
