DonalEvans commented on a change in pull request #6534:
URL: https://github.com/apache/geode/pull/6534#discussion_r643575658
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/NullRedisSortedSet.java
##########
@@ -49,4 +51,19 @@ long zadd(Region<RedisKey, RedisData> region, RedisKey key,
List<byte[]> members
byte[] zscore(byte[] member) {
return null;
}
+
+ @Override
+ byte[] zincrby(Region<RedisKey, RedisData> region, RedisKey key, byte[]
increment,
+ byte[] member) {
+ byte[] incr =
Coder.doubleToBytes(processIncrement(Coder.bytesToString(increment)));
Review comment:
The String might be changed by the method though, since there's some
logic around the +/- infinity values that can take e.g. an input of `"+inf"`
and turn it into a double value of `POSITIVE_INFINITY`, which then gets
converted by `Coder.doubleToString()` into `"Infinity"`. Two implementations
might be worth it, possibly "processIncrementToDouble" for the use in
`RedisSortedSet` and "normalizeIncrement" or something for the use here, where
we don't actually care about getting a double, just getting bytes that are
consistent with the way we handle infinities and trailing `".0"` elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
