nonbinaryprogrammer commented on pull request #6534: URL: https://github.com/apache/geode/pull/6534#issuecomment-853351247
> > @DonalEvans the stress new test failures are, for example: `expected <295.855182098051[84]> but was:<295.855182098051[96]>`. so that's why I had close to in that test. I guess I thought that that difference was a reasonable margin of error. but the 5% that I had in there is way too forgiving. So I think I'll add back the "close to" with a much smaller offset. > > Hmm. Do we know why the numbers aren't matching up exactly? If it's just a test issue then using "close to" is fine as a workaround, but I think it would be good to know exactly what's happening first, in case this is pointing to a possible issue in the implementation. I think that the numbers don't quite match because floating point math is hard for computers. it's accurate to a lot of decimal places. also native redis doesn't pass the test for equality. but they both pass with an offset of 0.00000001. I think that's pretty reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
