sabbey37 commented on a change in pull request #6534: URL: https://github.com/apache/geode/pull/6534#discussion_r644096414
########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZIncrByExecutor.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.executor.sortedset; + + + +import java.util.List; + +import org.apache.geode.redis.internal.executor.AbstractExecutor; +import org.apache.geode.redis.internal.executor.RedisResponse; +import org.apache.geode.redis.internal.netty.Command; +import org.apache.geode.redis.internal.netty.ExecutionHandlerContext; + +public class ZIncrByExecutor extends AbstractExecutor { + @Override + public RedisResponse executeCommand(Command command, ExecutionHandlerContext context) { + RedisSortedSetCommands redisSortedSetCommands = context.getRedisSortedSetCommands(); + List<byte[]> commandElements = command.getProcessedCommand(); + + byte[] increment = commandElements.get(2); + byte[] member = commandElements.get(3); + + byte[] retVal = redisSortedSetCommands.zincrby(command.getKey(), increment, member); Review comment: Not sure how much it matters, but I noticed we return `Infinity` or `-Infinity` while Redis returns `"inf"` or `"-inf"`. They explicitly handle the infinite case before returning a reply: ``` if (isinf(d)) { /* Libc in odd systems (Hi Solaris!) will format infinite in a * different way, so better to handle it in an explicit way. */ addReplyBulkCString(c, d > 0 ? "inf" : "-inf"); ... ``` ########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSortedSet.java ########## @@ -228,6 +231,31 @@ private void validateScoreIsDouble(byte[] score) { return members.get(member); } + byte[] zincrby(Region<RedisKey, RedisData> region, RedisKey key, byte[] increment, + byte[] member) { + byte[] byteScore = members.get(member); + double incr = processIncrement(Coder.bytesToString(increment).toLowerCase()); + + if (byteScore != null) { + double score = Coder.bytesToDouble(byteScore); + if (Double.isInfinite(score) && Double.isInfinite(incr)) { + throw new NumberFormatException(RedisConstants.ERROR_OPERATION_PRODUCED_NAN); + } + incr = score + incr; + } Review comment: This would cause the addition of +inf + +inf (or -inf + -inf) to also result in the NAN error, but it shouldn't (should just be +inf or -inf respectively). I'd prefer it if we checked the `incr` variable after doing the operation. Double actually has an `isNan` method: ``` if(Double.isNaN(incr)) { throw new ArithmeticException(ERROR_OPERATION_PRODUCED_NAN); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
