jdeppe-pivotal commented on a change in pull request #6605:
URL: https://github.com/apache/geode/pull/6605#discussion_r651766194



##########
File path: 
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/NullRedisData.java
##########
@@ -89,6 +96,25 @@ public boolean rename(Region<RedisKey, RedisData> region, 
RedisKey oldKey, Redis
     return false;
   }
 
+  @Override
+  public byte[] dump() throws IOException {

Review comment:
       Removed.

##########
File path: 
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/NullRedisData.java
##########
@@ -89,6 +96,25 @@ public boolean rename(Region<RedisKey, RedisData> region, 
RedisKey oldKey, Redis
     return false;
   }
 
+  @Override
+  public byte[] dump() throws IOException {
+    return new byte[0];
+  }
+
+  @Override
+  public RedisData restore(byte[] data, boolean replaceExisting) throws 
Exception {

Review comment:
       Removed

##########
File path: 
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/NullRedisData.java
##########
@@ -89,6 +96,25 @@ public boolean rename(Region<RedisKey, RedisData> region, 
RedisKey oldKey, Redis
     return false;
   }
 
+  @Override
+  public byte[] dump() throws IOException {
+    return new byte[0];
+  }
+
+  @Override
+  public RedisData restore(byte[] data, boolean replaceExisting) throws 
Exception {

Review comment:
       Removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to