jdeppe-pivotal commented on a change in pull request #6605:
URL: https://github.com/apache/geode/pull/6605#discussion_r651768381
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java
##########
@@ -234,7 +235,10 @@ private RedisResponse
getExceptionResponse(ChannelHandlerContext ctx, Throwable
}
}
- if (cause instanceof NumberFormatException) {
+
+ if (cause instanceof RedisException) {
+ response = RedisResponse.error(cause.getMessage());
+ } else if (cause instanceof NumberFormatException) {
response = RedisResponse.error(cause.getMessage());
} else if (cause instanceof ArithmeticException) {
response = RedisResponse.error(cause.getMessage());
Review comment:
Good suggestion. I've done that and also noticed a couple of other
exceptions that can be removed (related to function execution which we are not
doing anymore).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
