upthewaterspout commented on a change in pull request #6605:
URL: https://github.com/apache/geode/pull/6605#discussion_r660009329
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/AbstractRedisData.java
##########
@@ -207,6 +212,22 @@ protected void clearDelta() {
this.deltaInfo = null;
}
+ @Override
+ public byte[] dump() throws IOException {
+ ByteArrayOutputStream baos = new ByteArrayOutputStream();
+ DataSerializer.writeObject(this, new DataOutputStream(baos));
Review comment:
Interesting. Well, it looks like the native redis format has the version
information, just in the footer and not a header. I guess we are relying on
native redis to reject our dump files because the checksum won't match? And we
will reject native redis dump files because they don't have our magic bytes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
