sabbey37 commented on a change in pull request #6605: URL: https://github.com/apache/geode/pull/6605#discussion_r656226840
########## File path: geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/key/AbstractDumpRestoreIntegrationTest.java ########## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ + +package org.apache.geode.redis.internal.executor.key; + +import static org.apache.geode.redis.RedisCommandArgumentsTestHelper.assertExactNumberOfArgs; +import static org.apache.geode.test.dunit.rules.RedisClusterStartupRule.BIND_ADDRESS; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; + +import io.lettuce.core.KeyValue; +import io.lettuce.core.RestoreArgs; +import io.lettuce.core.cluster.RedisClusterClient; +import io.lettuce.core.cluster.api.sync.RedisAdvancedClusterCommands; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; +import redis.clients.jedis.HostAndPort; +import redis.clients.jedis.JedisCluster; +import redis.clients.jedis.Protocol; + +import org.apache.geode.internal.InternalDataSerializer; +import org.apache.geode.internal.serialization.DataSerializableFixedID; +import org.apache.geode.redis.RedisIntegrationTest; +import org.apache.geode.redis.internal.data.RedisHash; +import org.apache.geode.redis.internal.data.RedisSet; +import org.apache.geode.redis.internal.data.RedisSortedSet; +import org.apache.geode.redis.internal.data.RedisString; + +public abstract class AbstractDumpRestoreIntegrationTest implements RedisIntegrationTest { + + private RedisAdvancedClusterCommands<String, String> lettuce; + protected JedisCluster jedis; + private static String STRING_VALUE; + private static byte[] RESTORE_BYTES; + + @BeforeClass + public static void setupClass() { + InternalDataSerializer.getDSFIDSerializer().registerDSFID( + DataSerializableFixedID.REDIS_SET_ID, + RedisSet.class); + InternalDataSerializer.getDSFIDSerializer().registerDSFID( + DataSerializableFixedID.REDIS_STRING_ID, + RedisString.class); + InternalDataSerializer.getDSFIDSerializer().registerDSFID( + DataSerializableFixedID.REDIS_HASH_ID, + RedisHash.class); + InternalDataSerializer.getDSFIDSerializer().registerDSFID( + DataSerializableFixedID.REDIS_SORTED_SET_ID, + RedisSortedSet.class); + } + + @Before + public void setup() { + jedis = new JedisCluster(new HostAndPort(BIND_ADDRESS, getPort()), REDIS_CLIENT_TIMEOUT); + + RedisClusterClient client = + RedisClusterClient.create(String.format("redis://%s:%d", BIND_ADDRESS, getPort())); + lettuce = client.connect().sync(); + + STRING_VALUE = "It's a mad, mad, mad, mad, mad world"; + lettuce.set("set-dump-value", STRING_VALUE); + RESTORE_BYTES = lettuce.dump("set-dump-value"); + } + + @After + public void tearDown() { + flushAll(); + } + + @Test + public void dumpTakesExactlyOneArgument() { + assertExactNumberOfArgs(jedis, Protocol.Command.DUMP, 1); + } + + @Test + public void restoreErrorsWithUnknownOption() { + assertThatThrownBy( + () -> jedis.sendCommand("key", Protocol.Command.RESTORE, "key", "0", "", "FOO")) + .hasMessageContaining("ERR syntax error"); + } + + @Test + public void restoreFails_whenKeyAlreadyExists() { + lettuce.set("restored", "already exists"); + + assertThatThrownBy(() -> lettuce.restore("restored", 0, RESTORE_BYTES)) + .hasMessage("BUSYKEY Target key name already exists."); + } + + @Test + public void restoreFails_whenTTLisNegative() { + assertThatThrownBy(() -> lettuce.restore("restored", -1, RESTORE_BYTES)) + .hasMessage("ERR Invalid TTL value, must be >= 0"); + } + + @Test + public void restoreFails_whenTTLisNotANumber() { + assertThatThrownBy(() -> jedis.sendCommand("restored".getBytes(), Protocol.Command.RESTORE, + "restored".getBytes(), "not-an-integer".getBytes(), RESTORE_BYTES)) + .hasMessage("ERR value is not an integer or out of range"); Review comment: I definitely see your point, but I think we decided as a team to switch everything over to use the `stringToBytes` method from Coder. The only places we don't use that method (other than these dump/restore tests) are when we use a CHARSET other than UTF-8 or a random spot in `RedisString` that must've been overlooked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
