pivotal-jbarrett commented on a change in pull request #836:
URL: https://github.com/apache/geode-native/pull/836#discussion_r680092961
##########
File path: packer/build-windows-2016-vs-2017.json
##########
@@ -92,7 +92,8 @@
"choco install doxygen.install -confirm",
"choco install openssl -confirm",
"choco install strawberryperl -confirm",
- "choco install nuget.commandline -confirm"
+ "choco install nuget.commandline -confirm",
+ "choco install dotnet-5.0-sdk -confirm"
Review comment:
Our target is .NET 3.1 LTS. Does 5.0 SDK allow you to target 3.1?
##########
File path: netcore/CMakeLists.txt
##########
@@ -15,7 +15,7 @@
project(netcore LANGUAGES NONE)
-option(INCLUDE_DOTNET "" ON)
+option(INCLUDE_DOTNET "Dotnet 5" ON)
Review comment:
`option(INCLUDE_DOTNET_CORE "Build .NET Core client." ON)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
