pivotal-jbarrett commented on a change in pull request #836:
URL: https://github.com/apache/geode-native/pull/836#discussion_r680258035
##########
File path: netcore/CMakeLists.txt
##########
@@ -22,4 +22,7 @@ find_program(DOTNET dotnet)
if(DOTNET AND INCLUDE_DOTNET)
add_custom_target(netcore ALL COMMAND ${DOTNET} build --configuration
$<CONFIG> WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/NetCore VERBATIM)
add_custom_target(netcore-test ALL COMMAND ${DOTNET} build --configuration
$<CONFIG> WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/NetCore.Test DEPENDS
netcore VERBATIM)
+
+
+ install(FILES
${CMAKE_CURRENT_SOURCE_DIR}/NetCore/bin/$<CONFIG>/netcoreapp3.1/Apache.Geode.Netcore.dll
DESTINATION netcore/$<CONFIG>)
Review comment:
Pretty hard to confuse the two since both compile time and runtime would
fail. It seems common in the .NET space to have the assemblies and base package
names consistent and to distinguish different versions of the platform by
directory name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
