echobravopapa commented on a change in pull request #836:
URL: https://github.com/apache/geode-native/pull/836#discussion_r680189681
##########
File path: netcore/CMakeLists.txt
##########
@@ -22,4 +22,7 @@ find_program(DOTNET dotnet)
if(DOTNET AND INCLUDE_DOTNET)
add_custom_target(netcore ALL COMMAND ${DOTNET} build --configuration
$<CONFIG> WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/NetCore VERBATIM)
add_custom_target(netcore-test ALL COMMAND ${DOTNET} build --configuration
$<CONFIG> WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/NetCore.Test DEPENDS
netcore VERBATIM)
+
+
+ install(FILES
${CMAKE_CURRENT_SOURCE_DIR}/NetCore/bin/$<CONFIG>/netcoreapp3.1/Apache.Geode.Netcore.dll
DESTINATION netcore/$<CONFIG>)
Review comment:
This is true; its a bit verbose, but does ensure no one will confuse the
two .Net libraries...
any suggestions on the naming?
`Apache.Geode.Platinum.dll`
`Apache.Geode.Modern.dll`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
