dschneider-pivotal commented on a change in pull request #6814: URL: https://github.com/apache/geode/pull/6814#discussion_r701399500
########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/pubsub/AbstractClientSubscriptionManager.java ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + * + */ +package org.apache.geode.redis.internal.pubsub; + +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.function.Consumer; + +import org.apache.geode.redis.internal.netty.Client; + +abstract class AbstractClientSubscriptionManager<S extends Subscription> + implements ClientSubscriptionManager<S> { + private final Map<Client, S> map = new ConcurrentHashMap<>(); + /** + * This is used instead of map.size() because we need to + * make sure that once size goes to zero no further adds + * will be made to this manager. Instead a new manager + * needs to be created. + */ + private final AtomicInteger size = new AtomicInteger(1); + + public AbstractClientSubscriptionManager(S subscription) { + Client client = subscription.getClient(); + map.put(client, subscription); + } + + @Override + public int getSubscriptionCount() { + int result = size.get(); + if (result < 0) { Review comment: It no longer can so I've changed the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
