DonalEvans commented on pull request #6814: URL: https://github.com/apache/geode/pull/6814#issuecomment-912105624
@kirklund Regarding unit tests for the classes you mentioned; a decision was made by the folks who're working on the Geode Redis module to rely predominantly on integration tests to validate the behaviour of the Geode Redis API. Unit tests are used to test components that are not accessible via the API (such as object sizing for rebalance, the internal data structures that back the various RedisData classes etc.) but it was not considered worthwhile to also unit test methods that are covered in their entirety via integration tests. Adding unit tests to the classes you list would represent a fundamental change in testing approach for the group working on the Geode Redis module, and as such, it feels like something that would be better brought to the dev list if it's a change that you feel really needs to be made, since it was originally a deliberate choice rather than an oversight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
