dschneider-pivotal commented on a change in pull request #6814:
URL: https://github.com/apache/geode/pull/6814#discussion_r703714551
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/netty/StringBytesGlossary.java
##########
@@ -259,4 +260,17 @@
public static final byte[] bLEAST_MEMBER_NAME = new byte[] {-2};
public static final byte[] bNEGATIVE_ZERO = stringToBytes("-0");
+
+ @Immutable
+ public static final byte[] bMESSAGE = Coder.stringToBytes("message");
+
+ @Immutable
+ public static final byte[] bPMESSAGE = Coder.stringToBytes("pmessage");
+
+ @Immutable
+ public static final byte[] bUNSUBSCRIBE = Coder.stringToBytes("unsubscribe");
+
+ @Immutable
+ public static final byte[] bPUNSUBSCRIBE =
Coder.stringToBytes("punsubscribe");
Review comment:
These are actually used for responses and the redis docs say they are in
lower case. That was also how the implementation I started with sent them so I
think they should stay as they are. I will add a new section header comment
"Response Message Types" to try to make this clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
