nonbinaryprogrammer commented on a change in pull request #6961:
URL: https://github.com/apache/geode/pull/6961#discussion_r725314082
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/RedisConstants.java
##########
@@ -71,4 +72,16 @@
"AUTH called without a Security Manager configured.";
public static final String ERROR_KEY_REQUIRED =
"at least 1 input key is needed for ZUNIONSTORE/ZINTERSTORE";
+
+ /** System Properties **/
+ public static final String CONNECT_TIMEOUT_MILLIS =
"geode-for-redis-connect-timeout-millis";
+ public static final String WRITE_TIMEOUT_SECONDS =
"geode-for-redis-write-timeout-seconds";
+ public static final String INITIAL_DELAY_MINUTES =
"geode-for-redis-initial-delay-minutes";
+ public static final String INTERVAL_MINUTES =
"geode-for-redis-interval-minutes";
+
+ /** Default Values for System Properties **/
+ public static final int DEFAULT_REDIS_CONNECT_TIMEOUT_MILLIS = 1000;
Review comment:
all of the default values I used were what was already default in our
code. I do think it's worth having a conversation about what reasonable values
are for all these. that might be better as a synchronous conversation on Monday
(or whenever people have time)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
